-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand ‘Reproducibility’ docs page #226
Conversation
- Update and improve text to match current practice. - Add a list and scheme for external model names (#224)
@macflo8, requesting your review here as this tries to encapsulate our Slack discussion. Please let me know if there are particular points I made there that should be included here, and where. @behnam-zakeri, you asked in today's MESSAGE meeting about a list of model names; you can see here the kernel of it, with TODOs to expand over time. Please let me know if this arrangement and the surrounding text are sufficient. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=====================================
Coverage 59.5% 59.5%
=====================================
Files 195 195
Lines 15491 15491
=====================================
Hits 9225 9225
Misses 6266 6266 |
- Add link to doc/data. - Unroll 1-item list in "Other code" section. - Correct link to model-snapshot. - Link to node and year code lists.
@khaeru Thanks a lot for extending the reproducibility docs. I think it offers clear instructions and explanations on how the users should work with message-ix-models to ensure reproducibility of their modelling work. The most relevant discussion points from the slack discussion are covered well here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though my review wasn't requested, I skimmed the page out of interested and left some notes. All in all, looks good to me, though :)
How to review
PR checklist
Add or expand tests;coverage checks both ✅